Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several things I find useful #117

Merged
merged 6 commits into from
Dec 8, 2024
Merged

Conversation

hissssst
Copy link
Contributor

  • Monitoring without agent but with plain map instead
  • Enforce keys in state struct
  • Deprecation of Poolex.get_state in favor of :sys.get_state
  • High priority for Poolex process

Copy link
Owner

@general-CbIC general-CbIC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR!

Everything looks good, but I only have some small requests for change.

@general-CbIC
Copy link
Owner

Could you also describe your changes to CHANGELOG? 🙏🏻

@general-CbIC
Copy link
Owner

Closes #112
Closes #115

Co-authored-by: Aleksandr Sysoev <[email protected]>
@hissssst
Copy link
Contributor Author

hissssst commented Dec 7, 2024

@general-CbIC rereview please

@general-CbIC
Copy link
Owner

Thanks for update!
I will merge it and fix warnings by myself.

@general-CbIC general-CbIC merged commit c5d8b38 into general-CbIC:develop Dec 8, 2024
0 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants